Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set proof window #66

Merged
merged 2 commits into from
Sep 23, 2024
Merged

chore: set proof window #66

merged 2 commits into from
Sep 23, 2024

Conversation

onbjerg
Copy link
Contributor

@onbjerg onbjerg commented Sep 2, 2024

Currently optimism_outputAtBlock fails on op-reth because the proof window size defaults to 0. This sets it to 302400, which is roughly 1 week on a 2 second block time.

@parithosh
Copy link
Member

CI fails with this btw error: invalid value '302400' for '--rpc.eth-proof-window <RPC_ETH_PROOF_WINDOW>': 302400 is not in 0..=216000 @onbjerg

@onbjerg
Copy link
Contributor Author

onbjerg commented Sep 12, 2024

yeah sorry, this requires a release from our end. will ping here when it is

@onbjerg
Copy link
Contributor Author

onbjerg commented Sep 20, 2024

@parithosh this should work now on the latest image:)

@onbjerg
Copy link
Contributor Author

onbjerg commented Sep 23, 2024

Failure seems unrelated?

@parithosh
Copy link
Member

@onbjerg Yup agreed, error is unrelated :)
Merging the PR in now

@parithosh parithosh merged commit 24cff21 into ethpandaops:main Sep 23, 2024
3 of 5 checks passed
@onbjerg onbjerg deleted the patch-1 branch September 23, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants